gh-111810: Fix test_repr_deep from test_userlist on WASI
#112197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettcannon
approved these changes
Nov 17, 2023
|
The PR looks good, but it's dependent on #112223 going in first, hence the |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…ython#112197) Co-authored-by: Brett Cannon <[email protected]>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…ython#112197) Co-authored-by: Brett Cannon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's try this approach. I didn't change
list_testsat all, becausetest_listrelies on it and we need to test C stack limit unchanged. But, for Python structure, we need the lower recursion limit.test_repr_deepfromtest_userlisttriggers stack overflow protections for a debug build under WASI #111810